Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add podman:// support as replica of docker:// #1184

Open
shoffmeister opened this issue Aug 27, 2023 · 4 comments
Open

Add podman:// support as replica of docker:// #1184

shoffmeister opened this issue Aug 27, 2023 · 4 comments
Labels
enhancement Feature Request

Comments

@shoffmeister
Copy link

Is your feature request related to a problem? Please describe.

lnav git implements the docker:// URL scheme. Podman is a highly popular alternative, designed for running images in rootless mode.

Having podman:// URL scheme support for Podman would round off container logs support.

Describe the solution you'd like

URL scheme support for podman:// - quite literally a clone of docker://

The Podman CLI is designed to be fully compatible with the Docker CLI; the tooling is expected to have matching behaviour. Hence calling podman instead of docker should work well.

Describe alternatives you've considered

Installing a docker compatibility layer for podman would be a work-around only.

Docker and Podman do coexist and can be used concurrently. A docker compatiblity layer (basically soft-linking docker to podman) removes the option to use both docker and podman.

@shoffmeister shoffmeister added the enhancement Feature Request label Aug 27, 2023
@shoffmeister
Copy link
Author

https://kubernetes.io/docs/reference/generated/kubectl/kubectl-commands#logs would be another logical extension.

And https://access.redhat.com/documentation/en-us/openshift_container_platform/4.13/html/cli_tools/openshift-cli-oc#oc-logs (which would be a very similar with kubectl vs oc as above for docker and podman)

And as this will never end, the -e option probably will be the go-to route?

@tstack
Copy link
Owner

tstack commented Aug 28, 2023

Adding podman support seems reasonable.

And as this will never end, the -e option probably will be the go-to route?

The Custom URL feature is configurable, so folks can implement a URL scheme and publish it as a git repo that is installed by lnav -i. The -e option is good for one-offs or if the default behavior of the URL handler is not what is desired.

tstack added a commit that referenced this issue Aug 30, 2023
@shoffmeister
Copy link
Author

As to kubectl and oc I have started experimenting with https://github.com/shoffmeister/lnav-formats

ppsx pushed a commit to Inflight-Audio-Ltd/lnav that referenced this issue Feb 29, 2024
@tstack
Copy link
Owner

tstack commented Apr 11, 2024

As to kubectl and oc I have started experimenting with https://github.com/shoffmeister/lnav-formats

@shoffmeister Sorry, I missed following up on this... were you able to get things working? Are there any changes that could be done to make developing/debugging the URL handlers easier?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature Request
Projects
None yet
Development

No branches or pull requests

2 participants