Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3.7: async and await are now reserved keywords. #223

Open
kotepillar opened this issue Sep 18, 2018 · 3 comments
Open

python 3.7: async and await are now reserved keywords. #223

kotepillar opened this issue Sep 18, 2018 · 3 comments

Comments

@kotepillar
Copy link

please fix it : )

@matteing
Copy link

please.

@tbarbugli
Copy link
Collaborator

happy to review a PR, at the moment I am too busy at work to do this myself :(

@matteing
Copy link

matteing commented Apr 23, 2020

Working on one right now + updating redis to redis-py 3.0.

sidenote - we need better docs on testing... i spent hours getting unit tests to run.

UPDATE: Managed to bump redis-py to >=3, all unit tests are passing. (needed that for my project, as it uses redis-py>=3 as dependency already.

UPDATE 2: Also fixed a typo where async was not properly converted to async_. Trivial but important!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants