-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minification removing wasmbindgen getters #761
Comments
As trunk only calls With trunk, you can disable minification in release builds, using |
Agreed, I have also made an issue over there. However, the issue being here is still valuable as maybe a discussion can be had to disable minification by default when building for release. It seems like this isn't the only issue with minification. There is at least #750 and #758 on the first page besides this one. Perhaps it can also be documented somewhere that debug and release may have dragons because of unstable minification since it is enabled automatically. |
I am leaning towards closing this one, as it not directly a trunk issue, and the minification defaults will change in 0.20.0. |
Describe the Bug
This issue was first filed at wasm-bindgen here. It seems like someone there found that the minifier that trunk uses is removing some of the getter JS emitted by WasmBindgen in Release mode.
Steps to Reproduce
cargo install --locked trunk
trunk serve
localhost:8080
. Observe console log of "hello world"trunk serve --release
localhost:8080
. Observe console log of "function...."Expected Behavior
Debug and Release should be the same
Actual Behavior
Differing results in Debug and Release. See this comment
The text was updated successfully, but these errors were encountered: