Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a toast error message to the homepage for errors in JSON #102

Closed
wants to merge 5 commits into from
Closed

Conversation

kubahasek
Copy link
Contributor

Closes #77

Adds a toast to the homepage when there is an error in parsing the JSON provided.

@kubahasek kubahasek changed the title Issue 77 Adding a toast to the homepage for erros in JSON Oct 2, 2022
@ericallam
Copy link
Member

I just made a bunch of changes to get this to work, and pushed them to a branch on our repo. You can see the commit here:

12e31d0

If you can grab those changes and merge them into this PR, then we are in business

@kubahasek
Copy link
Contributor Author

@ericallam Do I understand correctly that I need to pull and merge my code with the changes you made and then we can merge?

@ericallam ericallam changed the title Adding a toast to the homepage for erros in JSON Adding a toast error message to the homepage for errors in JSON Oct 5, 2022
@ericallam
Copy link
Member

@kubahasek any luck with the merge? Anything I could help with?

Copy link
Contributor Author

@kubahasek kubahasek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merged main

@kubahasek
Copy link
Contributor Author

@ericallam Should be done now! Sorry, was swamped with school stuff so only got to it.

@ericallam
Copy link
Member

Thanks! Will take a look at this tomorrow and hopefully get it merged 👍

@ericallam
Copy link
Member

@kubahasek it looks like you merged in main, but I made the changes in this branch:

https://github.com/apihero-run/jsonhero-web/tree/kubahasek-issue-77

It might be easiest at this point to start a new PR, without the merge from main

@kubahasek
Copy link
Contributor Author

Alright, I will do that, sorry about that.

@kubahasek kubahasek closed this Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement error message when JSON is invalid syntax
3 participants