Adjust keycloak_required_action resource to not use metaparameter alias #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TuningYourCode
force-pushed
the
fix-keycloak-required-action-with-multiple-realms
branch
2 times, most recently
from
79c2af0
to
aa59cf0
Compare
TuningYourCode
force-pushed
the
fix-keycloak-required-action-with-multiple-realms
branch
from
0b15c30
to
dd3e2f0
Compare
|
This PR might be interpreted as breaking change as it might lead to issues if somebody was setting Also the code example in the There might be two options to solve the underlying issue:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will adjust the keycloak_required_action resource that it no longer uses the
aliasmetaparameter which leads to problems if you want to manage the same required action on multiple realms.The github issue #320 shows the exact code and error. I tested serveral ways but the current version does not allow to manage the same required action on multiple realms.
Fixes #320