Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception triggers when generating HTML output (for Go projects) #72

Open
Hamid-K opened this issue Jul 11, 2022 · 0 comments · May be fixed by #74
Open

Exception triggers when generating HTML output (for Go projects) #72

Hamid-K opened this issue Jul 11, 2022 · 0 comments · May be fixed by #74
Assignees
@ESultanik
Labels
bug Something isn't working

Comments

@Hamid-K
Copy link

Hamid-K commented Jul 11, 2022

Using the --output-format html (with or without -o out.html) results in the following exception and creation of an empty report file. I have encountered this only while auditing a Go project.

it-depends ../project-code/ --depth-limit 3 --output-format html:

Traceback (most recent call last):
  File "/Users/user/.pyenv/versions/3.8.12/bin/it-depends", line 8, in <module>
    sys.exit(main())
  File "/Users/user/.pyenv/versions/3.8.12/lib/python3.8/site-packages/it_depends/cli.py", line 201, in main
    output_file.write(graph_to_html(package_list, collapse_versions=not args.all_versions))
  File "/Users/user/.pyenv/versions/3.8.12/lib/python3.8/site-packages/it_depends/html.py", line 94, in graph_to_html
    graph = graph.collapse_versions()
  File "/Users/user/.pyenv/versions/3.8.12/lib/python3.8/site-packages/it_depends/dependencies.py", line 325, in collapse_versions
    version = max(p.version for p in instances)
TypeError: '>' not supported between instances of 'GoVersion' and 'GoVersion'

JSON and Dot output formats work as expected.
Tested with it-depends version 0.1.1 installed via pip on Python 3.8.12.
@ESultanik ESultanik self-assigned this Jul 29, 2022
@ESultanik ESultanik added the bug Something isn't working label Jul 29, 2022
ESultanik added a commit that referenced this issue Jul 29, 2022
@ESultanik
Makes GoVersion sortable which is required for HTML export (#72)
9dd6ab1
@ESultanik ESultanik linked a pull request Jul 29, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ESultanik ESultanik

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds the ability to compare Go versions trailofbits/it-depends
2 participants
@Hamid-K @ESultanik