You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
looks like that many drill files have rendering issue. I believe that mostly are due to wrong number format identification. I see the following code inside the file src/syntax/drill.ts at line 37 (5.0.0-alpha version) that is weird for me:
Is that correct? When t.value is 'LZ' we return TRAILING... it shouldn't be LEADING?
I've a drill file with "METRIC,TZ" but the rendering is completely wrong. I tried to change it to "METRIC,LZ" and then the rendering of drills is ALMOST correct! There's only an issue with G93X0Y0 that is interpreted as a hole (I've already seen this bug opened #353).
Other file with "INCH,TZ" renders correctly so I don't know if such condition should be inverted or if it's a problem only with "METRIC,TZ"...
The text was updated successfully, but these errors were encountered:
Hi,
looks like that many drill files have rendering issue. I believe that mostly are due to wrong number format identification. I see the following code inside the file
src/syntax/drill.ts
at line 37 (5.0.0-alpha version) that is weird for me:Is that correct? When t.value is 'LZ' we return TRAILING... it shouldn't be LEADING?
I've a drill file with "METRIC,TZ" but the rendering is completely wrong. I tried to change it to "METRIC,LZ" and then the rendering of drills is ALMOST correct! There's only an issue with G93X0Y0 that is interpreted as a hole (I've already seen this bug opened #353).
Other file with "INCH,TZ" renders correctly so I don't know if such condition should be inverted or if it's a problem only with "METRIC,TZ"...
The text was updated successfully, but these errors were encountered: