Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inaccurate typing for body/query argument getters #3336

Open
thijsvandien opened this issue Oct 7, 2023 · 0 comments · May be fixed by #3378
Open

Inaccurate typing for body/query argument getters #3336

thijsvandien opened this issue Oct 7, 2023 · 0 comments · May be fixed by #3378

Comments

@thijsvandien
Copy link

The return type of RequestHandler.get_argument depends on a default being provided or not, accounted for using appropriate overloads. Unfortunately, the same isn't true for RequestHandler.get_body_argument and RequestHandler.get_query_argument, which simply declare Optional[str].

Perhaps those need similar overloads, or they could be moved over to RequestHandler._get_argument, called by all...? I'm not sure if most type checkers would infer the rest from that.
pcavalar added a commit to pcavalar/tornado that referenced this issue May 17, 2024
@pcavalar
web: More accurate typing for get_{body,query}_argument()
6db0d9d 
Use the same overload technique as get_argument().

Fixes tornadoweb#3336
@pcavalar pcavalar linked a pull request May 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

web: More accurate typing for get_{body,query}_argument() pcavalar/tornado
1 participant
@thijsvandien