Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Embed media in rich text fields using Draftail #80

Open
glitchwolfe opened this issue Dec 5, 2019 · 6 comments
Open

Comments

@glitchwolfe
Copy link

Users should be able to embed Media objects into their content the same way they do Documents/Images. At the time of choosing, they should also be able to select if they want the video to autoplay, loop, and mute (similar to image formats).

I managed to get something like this working on one of my wagtail projects by reverse-engineering the existing modal chooser workflow for wagtailimages/documents, and would love to have this feature in a more official capacity. My solution is pretty hacky and doesn't use JSX or have unit tests, but I would be glad to help get this working in wagtailmedia once I have some time off.

Here are a few example screenshots:

Toolbar button

Chooser modal

Format chooser

Embedded media

@zerolab
Copy link
Member

zerolab commented Dec 6, 2019

Thank you @juan0tron, that would be a rather nice addition!

@thenewguy
Copy link
Collaborator

That would be an awesome addition!

@glitchwolfe
Copy link
Author

Sorry for the long wait! I've finally found the time to port my code over to this repo. There are some things that need to be addressed before I think it's ready to be merged in - advice on the best way to approach those issues would be much appreciated!

PR Here

Jon

@thibaudcolas
Copy link
Member

thibaudcolas commented Mar 3, 2020

I would love to help with this but have been struggling to find time for this project lately – so if others beat me to reviewing #90 then great. In any case this is looking very impressive @juan0tron!

@thibaudcolas
Copy link
Member

I’ve done an initial review review of #90. I think more feedback on the approach (not necessarily the details of the implementation) would be helpful.

@ordigital
Copy link

Is there a working solution for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants