Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Dev Build Header Populates Commit SHA #351

Open
sense-amr opened this issue Jan 23, 2024 · 6 comments
Open

Feature Request - Dev Build Header Populates Commit SHA #351

sense-amr opened this issue Jan 23, 2024 · 6 comments
Labels
dev help wanted Tasks that could be done by the community

Comments

@sense-amr
Copy link
Contributor

It would make it great for tracking bugs and development purposes if the Header of Dev Build could populate the used commit SHA ..

@pixtur pixtur added help wanted Tasks that could be done by the community dev labels Jan 27, 2024
@ylmrx
Copy link
Contributor

ylmrx commented Feb 11, 2024

this is gonna be difficult to achieve until we bite the CI bullet :)

It shouldn't be too complicated with the code part, but it make much more sense to then have the whole package pushed embedding the change in code (otherwise we'll have to deal w/ a LOT of maintainance commits).

i drafted the "pop the action" + replace part (reference the commit_id there is as trivial as $env:GITHUB_COMMIT_SHA) here : https://github.com/ylmrx/t3/blob/dev/.github/workflows/dotnet-desktop.yml

executed as: https://github.com/ylmrx/t3/actions/runs/7863244025/job/21453637444

(ps: as you most likely expect, and thus minimal at our scales, this might require a few bucks/month toward github too (worth it imho, but i have no idea about their pricing))

@pixtur
Copy link
Collaborator

pixtur commented Feb 13, 2024

I am not really sure. I think there are probably prebuild-scripts for MS-build to achieve this.

@ylmrx
Copy link
Contributor

ylmrx commented Feb 14, 2024

The example i'm showing in comment above is 95% the default prebuilt-script from github-actions.

also cf.
https://github.com/microsoft/github-actions-for-desktop-apps?tab=readme-ov-file#versioning
(linked in yml header)

@pixtur
Copy link
Collaborator

pixtur commented May 9, 2024

I think the current solution of the "build-standalone" solution is going to be obsolete as soon as we switch to the main branch.
We then should look in to CI/CD again.

@sense-amr
Copy link
Contributor Author

Great i look forward to the next iteration of the branch .. that solves the build standalone paradigm

@sense-amr
Copy link
Contributor Author

sense-amr commented May 9, 2024

Solving this issue in the main branch going forward could easily be achieved by Adding the aft requested
"About" option to the UI for the splash screen and or populate with version number in header

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev help wanted Tasks that could be done by the community
Projects
Status: Planned for v3.10
Development

No branches or pull requests

3 participants