Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ScretKey::sing & Signature::recover returned error #93

Open
elpiel opened this issue Jun 16, 2022 · 0 comments
Open

ScretKey::sing & Signature::recover returned error #93

elpiel opened this issue Jun 16, 2022 · 0 comments

Comments

@elpiel
Copy link
Contributor

elpiel commented Jun 16, 2022

Since https://docs.rs/ethsign/latest/ethsign/struct.SecretKey.html#method.sign returns the secp256k1 can we consider exporting the error or just use the ethsign::Error instead?

It would be nice to have SecretKey::sing directly use an array [u8; 32] instead of slice &[u8]. This would improve the api since the message should always be 32 bytes.

@elpiel elpiel changed the title ScretKey::sing returned error ScretKey::sing & Signature::recover returned error Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant