-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Admonish looks weird with the Rust theme #172
Comments
Agreed this doesn't look great - happy for some alternative that doesn't create such a high contrast element. I'm aware of this as we use the theme CSS variables to do the styling, which in this case are .rust :is(.admonition) {
background-color: var(--sidebar-bg);
color: var(--sidebar-fg);
} Honestly IMO the easiest thing might be to just add a hardcoded special case for the The place to start investigating that would be here - actually looks like we already have a bunch of overrides specifically for Rust, so maybe just hardcoding some hex values is fine:
|
This might not be a bug. But I find it weird.
I have created a book based off of https://rust-lang.github.io/mdBook/format/markdown.html which should show all of the distinct elements mdBook can render. It can be found here: book.tar.gz
It shows that no other element is using such dark colors in the body of the page with the Rust theme. This makes the admonish notes pretty disruptive. All of the notes immediately stand out from the page, even though they should just be additional informative notes (or something else).
The text was updated successfully, but these errors were encountered: