Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 17 support #713

Open
mgreca opened this issue Mar 18, 2021 · 21 comments
Open

React 17 support #713

mgreca opened this issue Mar 18, 2021 · 21 comments

Comments

@mgreca
Copy link

mgreca commented Mar 18, 2021

Currently, the peer dependencies of React are specified to be 16.0.0. Can we support React 17?

"react": "^16.0.0-0"
"react-dom": "^16.0.0-0"
@maclockard
Copy link

Looks like there is already a PR here: #681

@raptoria
Copy link

+1 for merging the PR, plz :)

@yuchonghua
Copy link

yuchonghua commented Jun 9, 2021

Look forward to supporting React17 soon
+1 for merging the PR, plz :)

@roelnoort
Copy link

+1 for merging this PR
Thx!

@BobDenar1212
Copy link

+1 for merging the PR, plz :)

@andredaniel
Copy link

+1 for merging the PR!

@repartay
Copy link

+100

@maclockard
Copy link

FWIW this library as it stands does work with react 17, you just get a peer dependency warning that you can ignore (at least with yarn)

@george-thomas-hill
Copy link

+1

@zachsa
Copy link

zachsa commented Aug 10, 2021

FWIW this library as it stands does work with react 17, you just get a peer dependency warning that you can ignore (at least with yarn)

So far as I know with NPM 7, you can either ignore all warnings or none. It's such a trivial thing to just make a new release with the peer dependencies versions updated.

@maclockard
Copy link

@zachsa completely agreed, just trying to help unblock folks.

@ururk
Copy link

ururk commented Aug 28, 2021

+1

1 similar comment
@andrelandgraf
Copy link

+1

@LuisOsta
Copy link

LuisOsta commented Nov 9, 2021

@tomkp Any updates?

@Nktech-Official
Copy link

please update for react@17..

@jasperoosthoek
Copy link

Could you please update for React 17?

@Campaio
Copy link

Campaio commented Jan 6, 2022

@tomkp any update on this?

@jasperoosthoek
Copy link

I've installed it using the npm install --force command and have been able to successful use it without any issues in development. However, this is not an ideal situation...

@neimarkbraga
Copy link

+1

@bburns
Copy link
Contributor

bburns commented Feb 18, 2022

These are the only changes that the pull request #681 includes -

image

So... I just did

npm install react-split-pane --force

I'm using FluentUI components and the splitter bar doesn't show up or work, but it does split the screen. Which I might as well do with css...

    <SplitPane split="vertical" defaultSize={140}>
      <Views neomem={neomem} />
      <Table neomem={neomem} />
    </SplitPane>

YMMV

@PauloSSAragao
Copy link

hello, any idea when react 17 will be supported? new version is 17.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests