Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See more than 5 pages of referrers #31

Open
alexgleason opened this issue Apr 18, 2019 · 1 comment
Open

See more than 5 pages of referrers #31

alexgleason opened this issue Apr 18, 2019 · 1 comment
Assignees

Comments

@alexgleason
Copy link
Collaborator

In ProjectTIER/projecttier.org#111 I've been asked to make the "next" button show more than 5 pages of results.

I'm guessing pages 1-5 are hardcoded in an GA API call somewhere. My plan is to request pages 5-10 once page 5 has been passed in the dashboard.

@alexgleason
Copy link
Collaborator Author

The API gets queried with a "max-results" field, set to 25 here: https://github.com/tomdyson/wagalytics/blob/master/client/src/wagalytics.js#L224

We could increase this value by a lot (increasing it to 500 still works over a range of 5+ years, but setting the range to 20 years will crash it).

Alternatively, we could detect when the final page is reached, then query the API for 5 more pages. This means actually writing code (technical debt), but could be worth it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant