Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Spinner doesn't work #34

Open
Uzzal-Bhowmik opened this issue Nov 7, 2024 · 2 comments
Open

bug: Spinner doesn't work #34

Uzzal-Bhowmik opened this issue Nov 7, 2024 · 2 comments

Comments

@Uzzal-Bhowmik
Copy link

Description

Although, showSpinner prop is set to true, the spinner doesn't seem to work for me.

Recording.2024-11-07.172629.mp4

Reproduction steps

<HolyLoader
      color="linear-gradient(to right, #65b545, #1b71a7)"
      height="3px"
      speed={250}
      easing="linear"
      showSpinner={true}
/>

- This is my code. And here showSpinner doesn't work!

Screenshots

No response

Logs

No response

Browsers

Chrome

OS

No response

@Uzzal-Bhowmik Uzzal-Bhowmik changed the title bug: <title>Spinner doesn't work bug: Spinner doesn't work Nov 7, 2024
@tomcru
Copy link
Owner

tomcru commented Nov 7, 2024

Thanks for the report, will look into what could be causing this.

@tomcru
Copy link
Owner

tomcru commented Nov 17, 2024

This issue is because the spinner is built with a border & borders do not accept linear-gradient out of the box. I will think about how to work this in. Options are to add a separate color prop for the spinner, rebuilding the spinners css to allow for gradients, or maybe even make a separate spinner component so styling it becomes a lot easier.

@tomcru tomcru closed this as completed in bea8f2f Nov 17, 2024
@tomcru tomcru reopened this Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants