-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
challenge number in the app project name #884
Comments
I think 21-anchor-scrolling would work. That's what we did at https://github.com/angularbootcamp/abc, when I worked on that. |
The eslint forbidden enum # 27 challenge is hard to find. Probably need to update the readme for that challenge to tell challengers to look under That challenge is one where the name of challenge doesn't match the filename as well ( If you add the numbers, the title and filenames don't have to match and you don't have to correct every mismatch. It would be nice to add the numbers to the Another thing to note -> If you change the file names to have numbers, do you have to update the generator as well? If you plan on doing a rework, I'd also think about re-categorizing some challenges. Move |
In addition to re-categorizing, I think some of the difficulty levels could be tweaked. For example, But to @jdegand's point, the difference between "Pure Pipe" and "pipe-easy" is a bit confusing. |
It is worse than I thought. There's at least 15 mismatched challenges. However, the command in the readme should clue challengers to the filename of the challenge. I think it will be signficantly easier to just change the title of the readme to match the existing filename. This might lead to some ugly titles, but it is a quick fix and it will be less error prone. You still will have to update all translation checklists in the other issues. This could also be a stop-gap measure if you want to do a significant rework. |
The challenge number would really help to navigate through the challenges. That's a good idea. Imo it would be great if we could use matching challenge titles & filenames. As @LMFinney already mentioned, the pipe challenge titles and filenames are a bit confusing. Re-categorizing is a good point as well. The new signal challenges should have a own signal category. |
thanks a lot for your feedback I can indeed re-categorize some challenges. |
Done |
Should I add the number of the challenge in the app project name ?
If you look at the folder, should it be:
and so one.
I don't know how hard is it to find the right challenge ?
Or maybe it is correct the way it is now
What do you think ?
The text was updated successfully, but these errors were encountered: