-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for setting metrics descriptions #67
Comments
I need this feature too. for example tracing::info!(
counter.request_count = 1,
histgram.request_duration = 500,
otel.description = "...",
); How should we handle otel.description in such a case? |
This is a great question, I haven't thought of it. Maybe it could use the name of the counter?
Just throwing out ideas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Feature Request
Motivation
Opentelemetry (and the rust crate) allow for setting descriptions to metrics, as seen in https://docs.rs/opentelemetry/0.20.0/opentelemetry/metrics/struct.InstrumentBuilder.html#method.with_description for example. It's just a handy feature that generates both code documentation and complementary information to the metric.
It'd be nice to allow this possibility via tracing-opentelemetry, so users using this API won't be limited. The same goes for .with_unit as well!
Proposal
Maybe it could work with specially named properties like we have with "otel.name", maybe on metric events a "otel.description" property or something.
Alternatives
I didn't think of anything
The text was updated successfully, but these errors were encountered: