-
Notifications
You must be signed in to change notification settings - Fork 469
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for editions #1031
Comments
I agree, editions are important. However, due to backwards compatibility of Are you willing to do the work to add this support? |
That makes sense. I won't have bandwidth for a couple months, but I'm down to contribute, especially after Prototiller is released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Editions are the future of protobuf syntax.
Currently, when you set
edition = "2023"
at the top of a.proto
file, and run it through prost-build usingprotoc_arg("--experimental_editions")
, it will panic on this line because the value ofFileDescriptorProto.syntax
is"editions"
. That's pretty much the extent of my investigation. I just figured I'd file this bug since support for editions doesn't seem to be tracked elsewhere.This may sound like it's adding complexity to Prost, but it looks like it should actually simplify Prost once Prototiller is released, since that will effectively normalize all the different syntaxes and editions into a canonical representation using features, and Prost will only have to support that canonical representation in the long term. It would be a somewhat heavy refactor up front, though.
The text was updated successfully, but these errors were encountered: