New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
syscall!
macros hide unsafe code
#1753
Comments
System calls are inherintly unsafe, I don't think add |
Closing because I don't think we need to do anything further here. |
While auditing mio for Fuchsia, I usually grep for
unsafe
and audit the unsafe blocks. However, thesyscall!
macros for unix and windows include their ownunsafe { .. }
blocks wrapping the underlying unsafe functions. This makes it harder to ensure that every syscall is properly justified. Removing the unsafe blocks from the macro would help solve this problem; whoever uses the macro would need to wrap it inunsafe { .. }
and provide a safety comment at the usage site.The text was updated successfully, but these errors were encountered: