Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RLIMIT_NOFILE #143

Open
FrankReh opened this issue Sep 15, 2022 · 3 comments
Open

RLIMIT_NOFILE #143

FrankReh opened this issue Sep 15, 2022 · 3 comments

Comments

@FrankReh
Copy link
Contributor

FrankReh commented Sep 15, 2022 •
edited

In Sep of 2021, with two commits, the liburing project added support to automatically try to increase the soft RLIMIT_NOFILE when its API functions hit the EMFILE error - there were two such API functions at the time. Since then, additional API functions have been added and each has also performed the same check against EMFILE and tried one time to increase the limit before having to return EMFILE to the caller.

Should this crate assume the same role in trying to increase the soft limit when EMFILE is encountered?
@FrankReh
Copy link
Contributor Author

I would like to soon provide a PR for the multishot accept operation and it would be nice to support the multishot accept direct operation as well, and so having a large sparse direct fd table setup could be quite common and hitting the soft RLIMIT_NOFILE seems more likely.

@Noah-Kennedy
Copy link

@FrankReh I'd say we should, conditional on a builder flag. I think we could let that flag be default though.

@FrankReh
Copy link
Contributor Author

@quininer What's your read on this? Would a PR that did this with a builder flag be acceptable?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@FrankReh @Noah-Kennedy