Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some TypeScript declarations are wrong #438

Open
ThisIsRex opened this issue Sep 15, 2021 · 1 comment
Open

Some TypeScript declarations are wrong #438

ThisIsRex opened this issue Sep 15, 2021 · 1 comment
Labels

Comments

@ThisIsRex
Copy link

Some TS declarations don't match the documentation
изображение
изображение

Full list (maybe I skipped something):
quat2.length quat2.squaredLength quat2.setReal quat2.dot

@stefnotch
Copy link
Collaborator

I think that's an unfortunate consequence of how the Typescript declarations have been written. A dual quaternion's length is the same as the length of the real part (the first 4 elements)

export const squaredLength = quat.squaredLength;

And the length of a quaternion is the same as the length of a vector

export const squaredLength = vec4.squaredLength;

This is probably worth fixing

@stefnotch stefnotch added the bug label Sep 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants