Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(y-indexeddb): cleanup #2207

Merged
merged 5 commits into from May 4, 2023
Merged

feat(y-indexeddb): cleanup #2207

merged 5 commits into from May 4, 2023

Conversation

sxzz
Copy link
Member

@sxzz sxzz commented May 2, 2023

No description provided.

@vercel
Copy link

vercel bot commented May 2, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
affine-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2023 8:29pm
affine-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 4, 2023 8:29pm

@vercel
Copy link

vercel bot commented May 2, 2023

@sxzz is attempting to deploy a commit to the toeverything Team on Vercel.

A member of the Team first needs to authorize it.

@vercel vercel bot temporarily deployed to Preview – affine-storybook May 2, 2023 09:33 Inactive
Copy link
Contributor

@himself65 himself65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a test case for the update?

@sxzz sxzz requested a review from himself65 May 3, 2023 13:42
@github-actions github-actions bot added the test label May 3, 2023
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 3, 2023 13:46 Inactive
@sxzz sxzz temporarily deployed to development May 4, 2023 00:13 — with GitHub Actions Inactive
@sxzz sxzz temporarily deployed to development May 4, 2023 00:13 — with GitHub Actions Inactive
@sxzz sxzz temporarily deployed to development May 4, 2023 00:13 — with GitHub Actions Inactive
@sxzz sxzz temporarily deployed to development May 4, 2023 00:13 — with GitHub Actions Inactive
@sxzz sxzz temporarily deployed to development May 4, 2023 00:13 — with GitHub Actions Inactive
@sxzz sxzz temporarily deployed to development May 4, 2023 00:13 — with GitHub Actions Inactive
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch coverage: 80.00% and project coverage change: -20.02 ⚠️

Comparison is base (6d7f06c) 68.50% compared to head (c1f5620) 48.48%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master    #2207       +/-   ##
===========================================
- Coverage   68.50%   48.48%   -20.02%     
===========================================
  Files         310      243       -67     
  Lines        6696     5410     -1286     
  Branches     1098      923      -175     
===========================================
- Hits         4587     2623     -1964     
- Misses       1914     2691      +777     
+ Partials      195       96       -99     
Flag Coverage Δ
e2etest ?
server-test 73.14% <ø> (ø)
storybook-test 50.69% <ø> (ø)
unittest 35.62% <80.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
packages/y-indexeddb/src/shared.ts 100.00% <ø> (ø)
packages/y-indexeddb/src/index.ts 86.32% <80.00%> (-2.18%) ⬇️

... and 208 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sxzz sxzz temporarily deployed to development May 4, 2023 00:16 — with GitHub Actions Inactive
@sxzz sxzz temporarily deployed to development May 4, 2023 00:18 — with GitHub Actions Inactive
@sxzz sxzz temporarily deployed to development May 4, 2023 00:18 — with GitHub Actions Inactive
@sxzz sxzz temporarily deployed to development May 4, 2023 00:18 — with GitHub Actions Inactive
@sxzz sxzz temporarily deployed to development May 4, 2023 00:18 — with GitHub Actions Inactive
@sxzz sxzz temporarily deployed to development May 4, 2023 00:18 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 00:21 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 00:21 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 00:21 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 00:21 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 00:21 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 00:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 00:25 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 00:25 — with GitHub Actions Inactive
@vercel vercel bot temporarily deployed to Preview – affine-preview May 4, 2023 00:29 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 4, 2023 00:33 Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 20:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 20:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 20:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 20:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 20:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 20:13 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 20:16 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 20:16 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 20:16 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 20:16 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 20:16 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 20:16 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 20:18 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 20:22 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 20:22 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 20:22 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 20:22 — with GitHub Actions Inactive
@himself65 himself65 temporarily deployed to development May 4, 2023 20:22 — with GitHub Actions Inactive
@himself65 himself65 merged commit 52b9734 into toeverything:master May 4, 2023
7 of 9 checks passed
@vercel vercel bot temporarily deployed to Preview – affine-preview May 4, 2023 20:26 Inactive
@vercel vercel bot temporarily deployed to Preview – affine-storybook May 4, 2023 20:29 Inactive
@sxzz sxzz deleted the feat/cleanup branch May 5, 2023 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants