Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auto focus the delete confirm button #5813

Open
1 task
golok727 opened this issue Feb 8, 2024 · 4 comments · May be fixed by #6284
Open
1 task

Auto focus the delete confirm button #5813

golok727 opened this issue Feb 8, 2024 · 4 comments · May be fixed by #6284
Labels
good first issue Good for newcomers story Features perceivable by end-users

Comments

@golok727
Copy link
Contributor

golok727 commented Feb 8, 2024 •
edited

Description

It would be better if the delete button in the confirmation modal is autoFocussed so that I can use the enter key instead of clicking the button to delete

Use case

No response

Anything else?

No response

Are you willing to submit a PR?

  • Yes I'd like to help by submitting a PR!
@golok727 golok727 added the story Features perceivable by end-users label Feb 8, 2024
@dev19Aman
Copy link

in which file is the confirm button located?

@golok727
Copy link
Contributor Author

golok727 commented Mar 13, 2024 •
edited

in which file is the confirm button located?

After taking a look at the code, it seems that the dialog from radix ui uses the enter key to close the modal instead of confirming it.

AFFiNE/packages/frontend/component/src/ui/modal/confirm-modal.tsx

Line 16 in 282b788

export const ConfirmModal = ({

https://www.radix-ui.com/primitives/docs/components/dialog#keyboard-interactions

@pengx17 pengx17 added the good first issue Good for newcomers label Mar 19, 2024
@pengx17
Copy link
Collaborator

pengx17 commented Mar 19, 2024

Not sure about this UX. What do you think @hwangdev97 ?

@rrajofficial7 rrajofficial7 linked a pull request Mar 24, 2024 that will close this issue
Open
@SambhavSetia SambhavSetia mentioned this issue May 14, 2024
Open
@hwangdev97
Copy link
Member

lgtm 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers story Features perceivable by end-users
Projects
AFFiNE Project
Status: 💡 Open
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(core): auto focus the delete confirm button rrajofficial7/AFFiNE
4 participants
@pengx17 @hwangdev97 @dev19Aman @golok727