Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support cookie restore in CookieSession #775

Open
pinkplus opened this issue Nov 6, 2023 · 0 comments
Open

Support cookie restore in CookieSession #775

pinkplus opened this issue Nov 6, 2023 · 0 comments
Labels
enhancement
Projects
Default Project

Comments

@pinkplus
Copy link

pinkplus commented Nov 6, 2023

#758 has added cookie restore support for CookieJar. However, it's not possible to use it with CookieSession.

CookieJar restoration is implemented with a static method LoadFrom, which always creates a new CookieJar instance. This doesn't work well with CookieSession, which initializes its own CookieJar instance and can't be replaced.

Is it possible to support cookie restoration in CookieSession as well?
@pinkplus pinkplus mentioned this issue Nov 6, 2023
Closed
@tmenier tmenier added this to Backlog in Default Project via automation Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
Default Project
  
Backlog
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pinkplus