Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FacebookAuthProvider and GoogleAuthProvider #33

Open
ibiza240 opened this issue Feb 6, 2017 · 2 comments
Open

FacebookAuthProvider and GoogleAuthProvider #33

ibiza240 opened this issue Feb 6, 2017 · 2 comments

Comments

@ibiza240
Copy link

ibiza240 commented Feb 6, 2017

is there a reason why the FacebookAuthProvider and the GoogleAuthProvider are not implemented the same way?

The Facebook provider derives from the FacebookAuthenticationProvider class while the Google provider implements the IGoogleOAuth2AuthenticationProvider interface...which way is better?

Cheers :)

@BrettKoenig
Copy link

Hi @ibiza240 these must be implemented in different ways. They are using the SDK's for their respective service. Google and Facebook have different API's, so each company will publish their own package that includes the lower level code to authenticate on their service. We get the luxury of just passing in a few parameters to their service and letting the code they essentially give us do the rest.

Does that make sense?

@BrettKoenig
Copy link

@tjoudeh this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants