Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Needs fixes for Mac/ARM #36

Open
1 task done
ItalyPaleAle opened this issue Dec 6, 2020 · 4 comments · May be fixed by #39
Open
1 task done

Needs fixes for Mac/ARM #36

ItalyPaleAle opened this issue Dec 6, 2020 · 4 comments · May be fixed by #39

Comments

@ItalyPaleAle
Copy link
Contributor

Prerequisites

  • I searched to see if the issue already exists.

Description

When running on macOS with Apple Silicon (ARM), the script correctly identifies the environment as GOOS=darwin and GOARCH=arm64

However, that combination will not be supported until Go 1.16

  1. For now (Go 1.15), gobinaries should ignore arm64 when using darwin, and instead return the amd64 binary
  2. When Go 1.16 is out, gobinaries could be updated to support arm64
@egoist
Copy link

egoist commented Feb 18, 2021

Go 1.16 has been released. 😄

@tj
Copy link
Owner

tj commented Feb 19, 2021

niice :D I'll try to remeber to re-deploy gobinaries next week

@cohix
Copy link

cohix commented Feb 27, 2021 •
edited
Loading

++ hoping for darwin/arm64 support soon :D

EDIT: happy to help testing with my M1 Mini

@grooverdan grooverdan mentioned this issue Apr 16, 2021
Closed
grooverdan added a commit to grooverdan/gobinaries that referenced this issue Apr 16, 2021
@grooverdan
bump to golang 1.16
8a4e6ce 
closes tj#36
closes datacharmer/dbdeployer#132

Just copying off d62cc32
@grooverdan grooverdan linked a pull request Apr 16, 2021 that will close this issue
Open
@egoist
Copy link

egoist commented Nov 23, 2021

Go 1.16 is also required for go:embed feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bump to golang 1.16 grooverdan/gobinaries
4 participants
@tj @ItalyPaleAle @cohix @egoist