Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version tags with fewer than 3 digits fail #29

Open
1 task done
vladimyr opened this issue May 10, 2020 · 1 comment
Open
1 task done

Version tags with fewer than 3 digits fail #29

vladimyr opened this issue May 10, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@vladimyr
Copy link

Prerequisites

  • I searched to see if the issue already exists.

Description

Docs say it is possible to use implicit semver wildcards:

Semver support

The following semver patterns are supported:

  • Exact version: v1.2.3, 1.2.3
  • Wildcards: v1.x, v1.2.x, 1.x, 1.2.x
  • Wildcards (implicit): v1, v1.2, 1.2
  • Leading v is optional, regardless of the Git tag

That was true until the internal semver package got swapped with go-semver: 1d14a73 which has stricter semver support and does not support wildcards.

Steps to Reproduce

curl -sf https://gobinaries.com/prdpx7/notes-cli | sh

This results with error: Error: Repository has no tags while prdpx7/notes-cli definitely has v0.1 tag.

What is the correct way to go forward with this one?
Fixing docs or refactoring go-semver so it supports implicit wildcards again? 🤔

@tj
Copy link
Owner

tj commented May 11, 2020

ahhh this is sort of a bug/gotcha, right now go-semver only supports x.x.x and vx.x.x, I think it's getting confused by two digits, we should definitely fix that though. Until then if you tag as v0.0.1 or v0.1.0 it should work

@tj tj changed the title Documentation is incorrect Version tags with fewer than 3 digits fail May 11, 2020
@tj tj added the bug Something isn't working label May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants