Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server-side entries search #134

Open
tivac opened this issue Aug 26, 2016 · 3 comments
Open

Server-side entries search #134

tivac opened this issue Aug 26, 2016 · 3 comments

Comments

@tivac
Copy link
Owner

tivac commented Aug 26, 2016

Currently search works against the entire set of entries in-memory, which is convenient but won't scale up to a large number of entries (See also, #133).

https://www.firebase.com/docs/web/guide/retrieving-data.html#section-queries describes how to query Firebase. Full-text search support on their end isn't great, but hopefully is good enough that we can filter by titles and show results to the user.

Results should be paginated using the same UI as #133.

@tivac tivac added this to the v0.4.0 milestone Sep 16, 2016
@tivac
Copy link
Owner Author

tivac commented Sep 16, 2016

@ctcleary This was fixed by #139 yes?

@ctcleary
Copy link
Contributor

Not exactly.

We have a bandage over the problem because we search the most recent 100 entries by default (and we can really easily up that number if needed). But the search still functions precisely the same way, so if a user needs to "search all" because their target isn't in the most recent 100 entries, it'll still be really slow.

Figuring out how to do the server side search felt like a separate issue. I can bump this to the top of my current issues priority list if'n you like.

@tivac
Copy link
Owner Author

tivac commented Sep 16, 2016

Ah, sure. I mis-remembered how your search impl from #139 worked. #138 is more important than this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants