Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"correlate"/"correlation" confusion in doe_lhs.py #4

Open
Arnoques opened this issue May 31, 2016 · 2 comments
Open

"correlate"/"correlation" confusion in doe_lhs.py #4

Arnoques opened this issue May 31, 2016 · 2 comments

Comments

@Arnoques
Copy link

Just a heads-up:

There's a mixup with the name for the correlation criterion for the Latin Hypercube. In doe_lhs.py, the documentation says "correlation" but the example says 'correlate'. The check in the code uses 'correlation', but later the if that actually selects the used function uses 'correlate'.

36:        "centermaximin" or "cm", and "correlation" or "corr". If no value 
88:        >>> lhs(4, samples=5, criterion='correlate', iterations=10)
98:            'centermaximin', 'cm', 'correlation', 
116:        elif criterion.lower() in ('correlate', 'corr'):

Thanks!

@tisimst
Copy link
Owner

tisimst commented May 31, 2016

You are correct. They all should be "correlate". Thank you for bringing that to my attention!

@cjekel
Copy link

cjekel commented Apr 2, 2020

I'd be happy to send a PR for this. I just ran into this issue today.

cjekel added a commit to cjekel/pyDOE that referenced this issue Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants