Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_lhscorrelate calculates correlation coefficient incorrectly #29

Open
rob5ives opened this issue Feb 14, 2021 · 0 comments
Open

_lhscorrelate calculates correlation coefficient incorrectly #29

rob5ives opened this issue Feb 14, 2021 · 0 comments

Comments

@rob5ives
Copy link

The correlation coefficient in _lhscorrelate is calculated as:
R = np.corrcoef(Hcandidate)
According to NumPy documentation, this function expects each row to be a variable; however, lhs treats the columns as variables. The correct way to calculate the correlation coefficient should be:
R = np.corrcoef(Hcandidate, rowvar=False)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant