Feautre tips view #418
Merged
Feautre tips view #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AkaShark
requested review from
NeverAgain11,
choykarl,
tisfeng,
CanglongCl,
Jerry23011 and
phlpsong
|
|
Jerry23011
reviewed
Feb 22, 2024
Let Me Look at it later |
… feautre_tips_view
|
Do we need to place a close button to let users remove the tips cell manually? |
phlpsong
requested changes
Feb 24, 2024
Easydict/Feature/ViewController/Window/BaseQueryWindow/EZBaseQueryViewController.m
Outdated
Show resolved
Hide resolved
We don't need to add this close button, when the user query text isn't empty this tips view will not appear. In one query action, it will appear once |
tisfeng
requested changes
Mar 5, 2024
Easydict/Feature/ViewController/Window/BaseQueryWindow/EZBaseQueryViewController.m
Outdated
Show resolved
Hide resolved
tisfeng
reviewed
Mar 5, 2024
tisfeng
reviewed
Mar 5, 2024
tisfeng
reviewed
Mar 7, 2024
Co-authored-by: Tisfeng <[email protected]>
tisfeng
previously approved these changes
Mar 8, 2024
phlpsong
previously approved these changes
Mar 9, 2024
tisfeng
approved these changes
Mar 10, 2024
phlpsong
approved these changes
Mar 10, 2024
|
最近频繁使用，这个功能误触发太多，我先 revert 了，稍后修复好再添加。 |
This was referenced Mar 30, 2024
Closed
tisfeng
added a commit
that referenced
this pull request
Mar 30, 2024
AkaShark
added a commit
to AkaShark/Easydict
that referenced
this pull request
Apr 7, 2024
This reverts commit 11fd868.
tisfeng
added a commit
that referenced
this pull request
May 19, 2024
* Revert "Revert "Feautre tips view (#418)" (#477)" This reverts commit 11fd868. * fix: #452 blank for tips view * feat: add type of tips cell * feat: support tips cell update cell type * fix: when selection translation the text is empty set special tips cell type * fix: update show tips status * fix: resolve merge dev * fix: update action type * pref: stash ocr error tips * fix: control show tips code * fix: update view * fix: add mini cell height * fix: tips cell type * fix: remove unuse code * fix: called showTipsView when showTips == true * fix: display when user just want show query window again * perf: improve displaying tips view * perf: do not reload tableView when starting query text * perf: remove unused Localizable.xcstrings * perf: close tips view when just updating query text * perf: close tips view when starting OCR image * chore(deps): bump rexml in the bundler group across 1 directory Bumps the bundler group with 1 update in the / directory: [rexml](https://github.com/ruby/rexml). Updates `rexml` from 3.2.6 to 3.2.8 - [Release notes](https://github.com/ruby/rexml/releases) - [Changelog](https://github.com/ruby/rexml/blob/master/NEWS.md) - [Commits](ruby/rexml@v3.2.6...v3.2.8) --- updated-dependencies: - dependency-name: rexml dependency-type: indirect dependency-group: bundler ... Signed-off-by: dependabot[bot] <[email protected]> * perf(UI): add icon for disableTipsView toggle * perf(UI): adjust advanced tab height --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Tisfeng <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Jerry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closed #404