-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link previews #820
Comments
Hello, is there someone working on this? if no, I am going to work on it. Thanks! |
No one is working on it. You are welcome to take a shot. Before you start, please describe how you are going to do it:
|
I am planning to proceed with these points in mind:
Thanks! |
As a separate service which gets called by a client? Please keep in mind that the server-proper does not do any message parsing right now and we do not want it to do the parsing. There is parsing in the push notifications module only. The server does not rewrite the messages and we don't want it to so.
Please expand on it a bit more. Also, keep in mind that the tinode clients do not have the ability to handle HTML right now and we have no plans to add such ability.
What kind of caching do you want to use? Thanks. |
ok, I will take some time on this and will update you. But if you have plan let me know. |
I see two options:
The option 1 is somewhat simpler, but will encounter captcha a lot more than 2. And it would require request throttling and caching. The option 2 is a bit more complex, because fetching and HTML parsing would have to be implemented independently for each client. And it won't just work for Javascript because of CORS: server would have to act as a proxy for requests from the JS clients. |
I prefer to go with Option 1 (Server fetching, sender-client rendering). If I understand correctly, the client itself will detect the link(s) and then fetch the preview details from the server, right? Also, would it be better for the message to wait until the server returns the preview data, or should the message text be sent immediately, with the preview appended later as an update? |
Yes, the client would detect the link. It does so already. I just checked: it looks like both Telegram and Whatsapp fetch site info while the message is being composed. |
@yinebebt, any update on this project? The server-side code is merged to devel and ready for release, but no client is using it. I don't want to release the server with unused code. Could you please update me on your plans to release link preview code in any of the clients? I would like to make a release within the next 10 days. If your work is taking longer, I'll move link preview code to a separate branch. Thanks. |
Hello, I haven't made progress on this yet. Let me know how the existing code detects links on the client, this will help me integrate it into the web client. However, I don't think it will be ready within the next 10 days. |
OK, then I'll move the code to a |
BTW, I don't think it would be a good location for the code. The communication with the server should be in the SDK, exported like It's not a simple project. |
I see, a frontend dev is better suited for this. Anyone can take it on, and I'll assist with the server side. |
Embedded previews of URLs
The text was updated successfully, but these errors were encountered: