Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for rules #17

Open
5 of 6 tasks
mkindahl opened this issue Aug 30, 2023 · 0 comments · Fixed by #22
Open
5 of 6 tasks

Add unit tests for rules #17

mkindahl opened this issue Aug 30, 2023 · 0 comments · Fixed by #22
Assignees
Labels
enhancement New feature or request

Comments

@mkindahl
Copy link
Collaborator

mkindahl commented Aug 30, 2023

Add unit tests for each rule so that we can check the case that it detects.

This means refactoring the code so that we can run each unit tests for a single rule only on a table or schema that we create based on some existing code. Since we want to avoid getting false positives if messages are changed, we should be able to get a "report" from a rule run that just contains the rule id and the parameters resulting from the SELECT. That way, we can just make sure that the rule triggers (or does not trigger) for particular objects in the database.

Example

[Add an example unit tests here.]

Tasks

Preview Give feedback
  1. enhancement
    mkindahl
  2. mkindahl
@mkindahl mkindahl added the enhancement New feature or request label Aug 30, 2023
@mkindahl mkindahl self-assigned this Sep 25, 2023
@mkindahl mkindahl linked a pull request Sep 26, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant