Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: Backspace keyboard event being received by pages #343

Open
grahamlangford opened this issue Nov 20, 2023 · 1 comment
Open

Bug: Backspace keyboard event being received by pages #343

grahamlangford opened this issue Nov 20, 2023 · 1 comment

Comments

@grahamlangford
Copy link

We've noticed that the Backspace keyboard event is propagating up from KBarSearch in some instances. So far we've only noticed the behavior on Notion.
@grahamlangford grahamlangford mentioned this issue Nov 22, 2023
Closed
@fregante
Copy link
Contributor

It's because kbar captures and stops the propagation of keypress, but doesn't handle keydown, which is what Notion uses for the backspace

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@fregante @grahamlangford