Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #414.
Converted some S3 classes to S7 in
form.R
andsession.R.
Notable changes:
rvest_field
allowed for dots to be passed. I noted that the dots were only ever used to pass one (optional) argument,options
; as such, I addedoptions
as a new property to the S7 implementation but did not include a way to pass the dots when creating arvest_field.
That is an easy fix if needed.Issues
Size: 821905
instead ofSize: 20707
as the snapshot asserts. I think this is an error with the test?