Skip alignment/stacking when possible #5789
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix #5788.
Briefly, when there is only 1 group with unique x variables,
stat_align()
+position_stack()
can be slow. By skipping alignment when there is only 1 group, we go down from ~2 seconds to ~700 milliseconds for 10e4 observations. By skipping stacking when all x positions are unique, we go from ~700 milliseconds to ~70 milliseconds. All in all, I'd say that 1 group, all unique x is common enough to make the skipping worth it.Created on 2024-03-21 with reprex v2.1.0