Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consider that xgboost converts data to 32 bit float internally #45

Open
ras44 opened this issue Apr 29, 2019 · 1 comment
Open

consider that xgboost converts data to 32 bit float internally #45

ras44 opened this issue Apr 29, 2019 · 1 comment
Labels
feature a feature request or enhancement

Comments

@ras44
Copy link

ras44 commented Apr 29, 2019

Hi @edgararuiz, I'm the author of the article mentioned by @JiaxiangBU in this issue. I wanted to mention the following in case if helps with development:

I discovered after writing the article was that xgboost converts data internally to 32-bit floats, and the resulting coefficients in the xgb.dump JSON correspond to this treatment. This might lead to errors, particularly with logistic regression objective functions. See the discussions at: dmlc/xgboost#4097

In other words, applying the coefficients as-is would assume the data in the database is represented as 32-bit floats. A good test would be to run xgboost predictions using the model binary (loaded via xgb.load) and then compare them with the tidypredict SQL results produced on the same data stored in a database, particularly for logistic regression objective functions.

I hope this is helpful!

@edgararuiz-zz
Copy link
Contributor

Ok, thank you for the heads up, I'll look into that.

@topepo topepo added the feature a feature request or enhancement label Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

No branches or pull requests

3 participants