New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn or error on wrong size/levels arg to grid functions? #364

Open

hfrick opened this issue Dec 16, 2024 · 0 comments

Member

hfrick commented Dec 16, 2024 •

edited

Loading

This warning should either be an error right away, or if we really want people to be able to continue with this mix-up, we should remove the stray argument so it doesn't interfer like it does here, causing an error later on with a surprising error message. This applies to all other grid functions with this type of warning as well. I'll turn it into a separate issue.

Originally posted by @hfrick in #362 (comment)

dials/R/space_filling.R

Lines 94 to 97 in caa3acc

    
           cli::cli_warn(c( 
        
             "{.arg levels} is not an argument to {.fn grid_space_filling}.", 
        
             i = "Did you mean {.arg size}?") 
        
           )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment