Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input check for new_param_grid() #354

Open
hfrick opened this issue Sep 23, 2024 · 1 comment
Open

Input check for new_param_grid() #354

hfrick opened this issue Sep 23, 2024 · 1 comment

Comments

@hfrick
Copy link
Member

hfrick commented Sep 23, 2024

Does this check ever get executed? Brought up by @EmilHvitfeldt #351 (comment)

dials/R/grids.R

Lines 261 to 265 in 555493b

if (!is.data.frame(x)) {
cli::cli_abort(
"{.arg x} must be a data frame to construct a new grid from."
)
}

@topepo
Copy link
Member

topepo commented Sep 23, 2024

No, I don't think so. Go ahead and remove it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants