Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github actions fails website postinstall task when hs2js is a workspace dependency #1106

Open
felixroos opened this issue May 19, 2024 · 0 comments
Labels
enhancement improves an existing feature

Comments

@felixroos
Copy link
Collaborator

felixroos commented May 19, 2024

follow up for #870 see #870 (comment)

when settings hs2js to "workspace:*", or when removing it and copying the wasm files from ../packages/tidal/node_modules/hs2js/dist/ .

in both cases, hs2js is a symlink, which probably somehow doesn't work in github actions.
It works when using an older version of hs2js, forcing pnpm to not create a symlink.
It should be noted that the dependency set in website is only for the tree-sitter wasm files.
The actual hs2js logic will be up to date, so the dep only needs to be updated when hsj2s rebuilds the wasm files with a newer version of tree-sitter / tree-sitter-haskell.

@felixroos felixroos added the enhancement improves an existing feature label May 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement improves an existing feature
Projects
None yet
Development

No branches or pull requests

1 participant