Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow customization of committer name and email #107

Closed
wants to merge 1 commit into from

Conversation

n0toose
Copy link

@n0toose n0toose commented Aug 20, 2023

This should fix #106 in theory.

@n0toose
Copy link
Author

n0toose commented Aug 20, 2023

Keep in mind that I do not have any considerable TypeScript experience and that this PR was not tested and made through "educated guesses" by using documentation, the Action itself, as well as and sample Actions provided by GitHub as a point of reference, as I currently do not have the necessary technical means to do so for ~2 weeks (and I would probably forget about making this PR later :D).

If you do not wish to review a PR that is not tested, feel free to set it as a WIP (and I'm sending my apologies in advance!) - I did not do so because I am hoping that there is not that much of a room for error.

@caesar
Copy link

caesar commented Aug 20, 2023

The code looks good to me but I'm also unsure how to go about testing a GitHub Action like this.

@n0toose n0toose closed this by deleting the head repository Sep 1, 2024
@tbertels
Copy link

The code looks good to me but I'm also unsure how to go about testing a GitHub Action like this.

That's best done using a testing repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make committer email configurable
3 participants