Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PRs created with this action trigger pull_request labelled event not pull_request #104

Open
pmalek opened this issue Aug 10, 2023 · 1 comment

Comments

@pmalek
Copy link

pmalek commented Aug 10, 2023

Problem statement

We have a CI that is configured to run on pull_request events on all branches: https://github.com/Kong/kubernetes-ingress-controller/blob/beac200706f81b9420d21b00653fd59a4040f8bb/.github/workflows/pr_checks.yaml#L12-L14.

Given an exemplar PR Kong/kubernetes-ingress-controller#4128 that got a label to be backported to release/2.10.x branch we received this PR Kong/kubernetes-ingress-controller#4131 which triggered only pull request labelled event not pull_request as it should. Hence we didn't get a full CI run as we'd like to: https://github.com/Kong/kubernetes-ingress-controller/actions?query=branch%3Abackport-4128-to-release%2F2.10.x

image

Expected behavior

PRs created by this action trigger pull_request event so that a full CI run can be triggered.

@pmalek
Copy link
Author

pmalek commented Aug 10, 2023

Looking at the https://github.com/tibdex/backport/blob/main/src/backport.ts#L113-L134 it does seem to do the correct thing (using https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#create-a-pull-request to create the PR) although I'm not sure if the timing of creating and labelling the PR isn't an issue here 🤔

Maybe labelling so quickly after creating prevents the creation event from going out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant