You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently in lib/stages/coding_style.sh the parameters --standard and --extensions are hard-coded. This is fine as a default, but if a project has its own phpcs.xml(.dist) file then these parameters override it and the customised config file is ignored.
The ideal solution would be to test for the existence of a phpcs.xml file and only if it is not present then add those two parameters to the call.
The text was updated successfully, but these errors were encountered:
I'm not sure if this project is still actively managed, so I won't start making a clone and trying out the fix, and making a PR until we have had some discusison. Thanks
Currently in lib/stages/coding_style.sh the parameters
--standard
and--extensions
are hard-coded. This is fine as a default, but if a project has its ownphpcs.xml(.dist)
file then these parameters override it and the customised config file is ignored.The ideal solution would be to test for the existence of a phpcs.xml file and only if it is not present then add those two parameters to the call.
The text was updated successfully, but these errors were encountered: