Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameters to make phpcs more flexible #67

Open
jonathan1055 opened this issue May 28, 2022 · 1 comment
Open

Add parameters to make phpcs more flexible #67

jonathan1055 opened this issue May 28, 2022 · 1 comment

Comments

@jonathan1055
Copy link

Currently in lib/stages/coding_style.sh the parameters --standard and --extensions are hard-coded. This is fine as a default, but if a project has its own phpcs.xml(.dist) file then these parameters override it and the customised config file is ignored.

The ideal solution would be to test for the existence of a phpcs.xml file and only if it is not present then add those two parameters to the call.

@jonathan1055
Copy link
Author

jonathan1055 commented May 28, 2022

I'm not sure if this project is still actively managed, so I won't start making a clone and trying out the fix, and making a PR until we have had some discusison. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant