Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a guide for Migrating to v1 #2518

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add a guide for Migrating to v1 #2518

wants to merge 3 commits into from

Conversation

nickcharlton
Copy link
Member

This intends to document everything we've heard as reported issues, to try and help users migrate as easily as possible.

It will collect a few issues before being merged, but this started with documenting the transitive dependency on sprockets-rails.

Closes #2514

@januszm
Copy link
Contributor

januszm commented Feb 15, 2024 •
edited
Loading

Upgrade from 0.19 to v1 beta causes the following errors on pages that use custom modifications in view templates:

ActionView::Template::Error
(undefined method `name' for ["", [
  #<Administrate::Field::Number:0x00007fe6741bc170..>,
  #<Administrate::Field::String:0x00007fe6741bc120..>,
  #<Administrate::Field::Email:0x00007fe6741bc080 ..>,
  ...
  #<Administrate::Field::BelongsTo:0x00007fe6741bb..>,
  #<Administrate::Field::String:0x00007fe6741bbd60..>,
  #<Administrate::Field::String:0x00007fe6741bbcc0..>,
  #<Administrate::Field::String:0x00007fe6741bbb80..>,
]]:Array)

Plus a bunch of weird frontend issues, like Search input becomes blue on hover, or Datepicker not working at all. Does it use Bootstrap 5 ? and if yes, if the main app already uses Bootstrap 4.6

@nickcharlton nickcharlton mentioned this pull request Feb 16, 2024
Closed
@nickcharlton
Copy link
Member Author

I've extracted your comment out into another issue, so we can better understand it there: #2522

@nickcharlton
Add a guide for Migrating to v1
71ce7db 
This intends to document everything we've heard as reported issues, to
try and help users migrate as easily as possible.

It will collect a few issues before being merged, but this started with
documenting the transitive dependency on `sprockets-rails`.

Closes #2514
@nickcharlton
Add a mention of template changes
c3c640a 
This addresses some comments raised in #2522.
@nickcharlton
Add some more detail on field changes
404c6c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Document the removal of the transitive sprockets-rails dependency
2 participants
@nickcharlton @januszm