Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[remix-gql-tailwind] Audit kit to make sure it's up-to-date in comparison to showcase #314

Open
tvanantwerp opened this issue Sep 30, 2022 · 3 comments · May be fixed by #317
Open

[remix-gql-tailwind] Audit kit to make sure it's up-to-date in comparison to showcase #314

tvanantwerp opened this issue Sep 30, 2022 · 3 comments · May be fixed by #317
Assignees
Labels
question Further information is requested

Comments

@tvanantwerp
Copy link

No description provided.

@tvanantwerp tvanantwerp added the question Further information is requested label Sep 30, 2022
@tvanantwerp tvanantwerp self-assigned this Sep 30, 2022
@tvanantwerp
Copy link
Author

Storybook's main.js is out of date. It reads:

        alias: {
          remix: path.resolve(__dirname, '../__mockRemix__'),
        },

But it should read:

        alias: [
          {
            find: '@remix-run/react',
            replacement: path.resolve(__dirname, '../__mockRemix__'),
          },
        ],

@tvanantwerp
Copy link
Author

.prettierrc could use a few more rules. Currently only enforces trailing comma and single quote rules.

ESLint rules are all over the place between the kit and the showcase. Somehow, the showcase had both an eslintrc.js and an eslintrc.json... Needs consolidation.

@tvanantwerp
Copy link
Author

Does not use husky and git hooks to lint and format code pre-commit like the showcase does.

@tvanantwerp tvanantwerp linked a pull request Oct 7, 2022 that will close this issue
@dustinsgoodman dustinsgoodman added this to the Remix + GQL + Tailwind milestone Oct 10, 2022
@markshenouda markshenouda self-assigned this Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants