Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add a license to this package #79

Open
docwilmot opened this issue Jan 15, 2019 · 6 comments
Open

Please add a license to this package #79

docwilmot opened this issue Jan 15, 2019 · 6 comments

Comments

@docwilmot
Copy link

Hello, thanks for all your work, it is really appreciated. I am with the Backdrop CMS team (Backdrop is a fork of Drupal), and I ported Mailchimp for Backdrop, based on the Drupal module. I am in the process of updating the code to the latest Mailchimp Drupal version, but Backdrop has by principle encouraged bundling external libraries directly into contrib modules to ease the user experience, more so in recent times, since after my initial port, which used Libraries module. I couldnt find any statement about licencing on your libraries so thought I'd ask if this is permitted. Or if you had any objection to this technically of philosophically. Would be grateful for your thoughts.
Thanks.

@xurizaemon
Copy link

xurizaemon commented Aug 27, 2021

@docwilmot thanks for opening this. We've identified that this package is an unlicensed dependency of one of our projects as well. We're using it as a dependency of the Mailchimp module for Drupal 9. Can I suggest we rename this issue to "Please add a license to this package", since the issue IMO affects any project wishing to use the library which needs to consider component licensing.

By having no license, my understanding is that the "default state" of projects is "all rights reserved" (IANAL, likely varies by jurisdiction, caveat caveat). This introduces considerations both for those wanting to contribute to the package, and those wanting to consume it.

@docwilmot docwilmot changed the title Bundling the library in Backdrop CMS contrib Please add a license to this package Aug 27, 2021
@docwilmot
Copy link
Author

Good idea, done. But after 2 years actually forgot about this, wonder if there will be a response.

@xurizaemon
Copy link

xurizaemon commented Aug 27, 2021

Thanks! It's worth a try - I've also flagged the issue at https://www.drupal.org/project/mailchimp/issues/3230265 because the dependency affects users of that module, hoping someone from Thinkshout will notice the omission and be able to address it.

It would be trivial to do but presumptive of me to MR a license in, so I'm hoping drawing the organisation's attention to (IMO likely unintended) missing license is a useful way to contribute to fixing it.

Some other Mailchimp client libs and their licenses:

Library License
python-mailchimp-api MIT
drewm/mailchimp-api MIT
nztim/mailchimp-api MIT
ebizmarts/mailchimp-lib MIT

Mailchimp's own client libraries use a Mailchimp-specific license which probably isn't appropriate here.

Greg-Boggs added a commit to Greg-Boggs/mailchimp-api-php that referenced this issue Aug 27, 2021
Adding an open source license that matches the license for the Drupal MailChimp module based on the request in thinkshout#79
@Greg-Boggs
Copy link
Contributor

I'm guessing this got over looked because Drupal modules have the license attached automatically during packaging. So, I created a Pull Request.

@bbrala
Copy link

bbrala commented Nov 18, 2021

I would say add MIT, but we really need a maintainer to chip in here :)

@xurizaemon
Copy link

Fixed via #104

This issue can be closed now :) Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants