Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fromAPI issue #7

Open
whusterj opened this issue Apr 30, 2022 · 0 comments
Open

fromAPI issue #7

whusterj opened this issue Apr 30, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@whusterj
Copy link
Member

This was reported internally on the ThinkNimble slack some time ago:


I ran into an issue with the TN models that Pari just helped me to solve. Just wanted to alert you, in case that means the code needs to be changed.

I was calling the List method, but it was conking out when mapping the results through FromAPI. I looked in the repo, and the code was

static fromAPI(json = {}) {
    return new this(objectToCamelCase(json))
  }

when we changed it to

static fromAPI(json = {}) {
    return new User(objectToCamelCase(json))
  }

This should be investigated - this in the static fromAPI method provided by tn-models should refer to the enclosing class, but for some reason was not in this case.

@whusterj whusterj added the bug Something isn't working label Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant