Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection Manager: improvements #142

Open
lakardion opened this issue Jul 24, 2023 · 1 comment
Open

Collection Manager: improvements #142

lakardion opened this issue Jul 24, 2023 · 1 comment
Labels
bug Something isn't working enhancement New feature or request

Comments

@lakardion
Copy link
Member

@paribaker Can you fill in here what problems you encountered with the current version of the collection manager?

I believe your request about the immutability handling is how it should be working? So probably the getter is not the right approach for the collection manager to work with Vue

We're doing a spread of the list on every update so the ref should change:

list = [...(append ? list : []), ...data.results]

@lakardion lakardion added bug Something isn't working enhancement New feature or request labels Jul 24, 2023
@paribaker
Copy link
Contributor

In theory this should work but the Vue elements do not seem to update! A temporary workaround for users is to use
triggerRef(objct)
I wonder if an Object.assign(myCollection, myCollection) would work --- I tried this in the vue component but it does not!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants