Dependency php-zts missing?

[alex-harvey-z3q]

I have inherited a system using this puppet-nagios module and the person who set it up has applied a hack to install a missing php-zts package as follows -

diff --git a/manifests/server.pp b/manifests/server.pp
index 8f405a7..2f27780 100644
--- a/manifests/server.pp
+++ b/manifests/server.pp
@@ -193,6 +193,9 @@ class nagios::server (
     class { '::php::mod_php5': }
     php::ini { '/etc/php.ini': }
     if $php_apc { php::module { 'pecl-apc': } }
+    package { 'php-zts':
+      ensure => installed
+    }
   }

   # Configuration files

I would like to fix this properly by either submitting a patch upstream or refactoring appropriately. Looking at the code I wonder if the correct solution would be to submit a patch against thias-php?

[alex-harvey-z3q]

Some feedback on these issues would enable me to submit an appropriate pull request. Thanks! :)

[thias]

Well... I don't really know what to say.... let's try anyway :

Do things not work without the php-zts package installed? (because it does for me!)

Depending on the above, either it's completely optional and you should just add that to your node, or use something like php::module { 'zts': } to get proper ordering and hopefully web server reload, either it's required and I'll need to add it to the module.

I would also accept a pull request to make the installation of that package optional for the nagios::server class.

[alex-harvey-z3q]

I see. I will need to rebuilt one of the nagios servers then myself to figure out why the package was added.