-
-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[@thi.ng/geom-resample] Angular resolution resample unimplemented #345
Comments
Hi @blainelewis1 - the umbrella/packages/geom/src/vertices.ts Line 152 in cfc8590
umbrella/packages/geom-arc/src/sample.ts Line 34 in cfc8590
The reason the option is listed in the In any way, for now I should add a more explicit note to the |
I actually also just had this exact misunderstanding. I was trying to find a way of specifying that I wanted samples to be every d distance, but to have the sampler automatically increase resolution if the curvature of the path reached a certain threshold. I finally realized that this combination of constraints wasn't possible, but I did spend some time trying to figure it out. |
I noticed there is a parameter to resample to angular resolution: https://github.com/thi-ng/umbrella/blob/develop/packages/geom-api/src/sample.ts
However, I am not getting the expected result when I use
theta
as a parameter:Expected:
Received:
I believe this is just the default behaviour and the resample by angular resolution is unimplemented, see:
https://github.com/thi-ng/umbrella/blob/develop/packages/geom-resample/src/simplify.ts
and
https://github.com/thi-ng/umbrella/blob/develop/packages/geom-resample/src/resample.ts
Neither mention
theta
which I think means the feature was documented but not implemented.The text was updated successfully, but these errors were encountered: